-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser removal/addition data guidelines #7244
Add browser removal/addition data guidelines #7244
Conversation
This change adds data guidelines on removal of existing browsers from BCD, and addition of new browsers to BCD. Related: mdn#7238
(@ddbeck It seems the auto-labeler didn't catch this PR. Perhaps a problem with the glob?) |
@vinyldarkscratch I opened #7250 to track the labeler problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this, @sideshowbarker. One suggestion in a line comment.
(Like the removal PR, this will likely be blocked until I hear back from Chris. I don't actually anticipate this proposal being rejected though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few more suggestions, now that I've had some distance from this. Thank you!
Doublechecked them all and everything looks good, except that I see we’ve got a lint failure. Will investigate right now |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
90dffc7
to
3ee5226
Compare
OK, pushed a fix and we’re now all green again for CI/lint |
Thanks for coming up with these guidelines. Long overdue to specify this :-) The original browsers in BCD are based on what the MDN wiki had in the old compat tables which were added by MDN contributors over the years. The wiki had sets of different browsers on different pages, but there was a set of browsers that occurred often. So, BCD came to its original list of browsers via the data migration and avoiding to lose information. I remember BCD added and removed Servo. I think a removal reason was that there aren't real releases and versions numbers. Another removal that I remember is Edge mobile. See #3888. It seems to retroactively meet the removal criteria mentioned here. Finally, I'd like to mention that BCD's Opera and Opera Android data seems to (almost) meet our removal criteria. Is there another criteria that makes us keep opera? Is it (historical) marketshare? Something else? |
@Elchi3 Good points on this, thank you for taking a look. In general, my original proposal was meant to be a guideline for making a holistic decision, weighted heavily toward what's good for BCD consumers and their readers. Perhaps we could rephrase things to say something like, "BCD owners will consider the following…" to show that it's not a complete or absolute set of criteria. This might help with a few of these other issues. To your more specific points:
Yeah, I was trying to capture something like this with the published release information proposal. I wanted something a bit more substantial than being able to populate a browser data file. I want to know about release process and plans too. I'm open to rewording this, if you've got any ideas.
I don't want to bind us to this. For the removals we have pending, I'm not even sure who I would contact and I don't think there would be any change in the outcome based on that conversation. I'd welcome the return of those browsers, but it seems preferable in a lot of ways to start from scratch. And if a browser has vendor participants here, I would expect (and ask) for their help on matters related to that browser prior to removal anyway.
This is a good point. I think the biggest open question there is downstream: do MDN or caniuse readers care? I think if we adopt these guidelines, then we should open an issue to investigate this. The answer might be to keep it (we do update Opera data rather frequently), but it's not a bad idea to take a look. |
Makes sense to me. After all, a removal or an addition will be discussed in an issue anyways and arguments will be weighted against each other. The guidelines here provide general guidance and hopefully allow us to consider criteria more fairly for the various requests.
Yep, makes sense. I think we don't need to add anything about it then.
Yeah, opening an issue for discussion is a must have for adding/removing a browser. I think this is obvious, but if anyone cares strongly, it could also be mentioned in the guideline that there must be a discussion in an issue about the case. |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're ready to go on this. Thank you, @sideshowbarker and @Elchi3 for making this really solid! 🎉
This change adds data guidelines on removal of existing browsers from BCD, and addition of new browsers to BCD.
Related: #7238