Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta Safari from iOS 14.2 and Big Sur 11.0.1 #7248

Closed
wants to merge 1 commit into from

Conversation

Constellation
Copy link
Contributor

  • iOS 14.2 Release Candidate (18B91)
  • macOS Big Sur 11.0.1 beta (20B5012d)

https://developer.apple.com/news/releases/

to list Safari data for Intl[@@toStringTag] in #7020.

@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Nov 3, 2020
@Constellation Constellation mentioned this pull request Nov 3, 2020
@Constellation
Copy link
Contributor Author

@foolip Could you review this PR? Thanks!

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 3, 2020

Thanks for starting this PR, @Constellation. For posterity, could you inline additional details from the Apple site in the PR description? The seemingly-relevant pages linked from https://developer.apple.com/news/releases/ require a sign-in and I find that Apple developer links tend to break rather often anyway. Some additional detail (such as how you found the webkit version numbers) would be helpful to reviewing this and to understanding this change if it ever needs to be revisited in the future. Thank you again!

- iOS 14.2 Release Candidate (18B91)
- macOS Big Sur 11.0.1 beta (20B5012d)

from https://developer.apple.com/news/releases/ to list Safari data for `Intl[@@toStringTag]` in mdn#7020.
The WebKit and Safari versions are checked by installing OSes, and opening "About Safari" prompt.
@Constellation
Copy link
Contributor Author

Thanks!

Thanks for starting this PR, @Constellation. For posterity, could you inline additional details from the Apple site in the PR description? The seemingly-relevant pages linked from https://developer.apple.com/news/releases/ require a sign-in and I find that Apple developer links tend to break rather often anyway.

I think the release notes will become ready after the beta software is released. So at this point, there is no URL for document. I think this is the same to chrome.json's beta versions.

Some additional detail (such as how you found the webkit version numbers) would be helpful to reviewing this and to understanding this change if it ever needs to be revisited in the future. Thank you again!

I installed these softwares and checked version by opening "Safari">"About Safari" menu. It shows Safari version (in this case, 14.0.1, and WebKit build 610.2.11).

@Constellation
Copy link
Contributor Author

The screenshot from installed macOS Big Sur 11.0.1 beta (20B5012d).

Screen Shot 2020-11-03 at 5 25 09 AM

@foolip
Copy link
Contributor

foolip commented Nov 3, 2020

Do we have confirmation that iOS 14.2 will use a different version of WebKit from a phone with the beta installed? In the past, more often than not it's been the x.3 release that bumps WebKit, and this usually happens ~6 months about the x.0 release.

@Constellation
Copy link
Contributor Author

Do we have confirmation that iOS 14.2 will use a different version of WebKit from a phone with the beta installed?

Yes, iOS 14 and iOS 14.2 are shipping different versions of WebKit, and its WebKit revision is 610.2.11, this is the same to Big Sur's latest beta's WebKit. I installed and checked WebKit's plist information.

It seems that browser-compat-data is using iOS version for iOS Safari while Safari has different version number (in this case, iOS Safari version is 14.0.1 too), I used 14.2 for iOS and 14.0.1 for macOS (since in macOS, Safari 14 can be installed into Catalina etc.).

@Constellation
Copy link
Contributor Author

Ping review :)

@foolip
Copy link
Contributor

foolip commented Nov 5, 2020

I'm going to have to defer to @ddbeck on this, I know BCD skips some Safari releases which are too similar, but I don't know if this is going to be one of those. Since Safari 10, each release in BCD as included a bump to the WebKit major version, and that's not the case here.

I've tried to work out from https://trac.webkit.org/log/webkit/tags/Safari-610.1.28 + https://trac.webkit.org/log/webkit/tags/Safari-610.2.11 how much change from WebKit trunk (if any) is included but don't know how, since all my VCS skills are with Git and WebKit tags/branches aren't included in the Git mirror.

cc @vinyldarkscratch given #5846.

cc @sideshowbarker given #6896.

@queengooborg
Copy link
Contributor

For browser versions, we don't really record patch versions as separate versions. This decision was made under the expectation that users are likely to run the latest patch of the minor version of a browser. Thus, if there are any new features added to 14.0.1, we'd record it as 14. (See https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#release-lines-and-backported-features)

@Constellation
Copy link
Contributor Author

So, for features that is enabled on Safari 14.0.1, should we just record it as 14 feature?

@Constellation
Copy link
Contributor Author

@vinyldarkscratch OK, I'll open a PR that records Intl[@@toStringTag] as Safari 14.

Another question: so, next time, when patched version of Safari is in beta, and the feature is implemented in that beta (in this case, Intl[@@toStringTag]), can we just mark it as a major released feature (since we do not have an entry to this beta, and this will be marked as a major released one anyway)?

Constellation added a commit to Constellation/browser-compat-data that referenced this pull request Nov 5, 2020
Based on discussion in mdn#7248, we mark it as Safari 14 feature.
@queengooborg
Copy link
Contributor

So, for features that is enabled on Safari 14.0.1, should we just record it as 14 feature?

That's correct! Anything in Safari 14.0.x should be recorded as Safari 14 -- once we reach Safari 14.1, then we'll add that new version.

Another question: so, next time, when patched version of Safari is in beta, and the feature is implemented in that beta (in this case, Intl[@@toStringTag]), can we just mark it as a major released feature (since we do not have an entry to this beta, and this will be marked as a major released one anyway)?

Overall, I recommend avoiding adding results for browsers while they're still in beta (and especially any releases under the canary channel, including Safari Technology Previews). Sometimes, a browser may release a feature that is available in that beta, but will back out of it or place it behind a disabled flag due to instability or otherwise.

@Constellation
Copy link
Contributor Author

Thanks!

Overall, I recommend avoiding adding results for browsers while they're still in beta (and especially any releases under the canary channel, including Safari Technology Previews). Sometimes, a browser may release a feature that is available in that beta, but will back out of it or place it behind a disabled flag due to instability or otherwise.

OK, so, should we avoid including beta releases of Firefox and Chrome too? Chrome and Firefox also have beta and nightly entries, and #7020's Intl feature is only available in beta in Firefox.
https://github.com/mdn/browser-compat-data/blob/master/browsers/chrome.json#L602-L611
https://github.com/mdn/browser-compat-data/blob/master/browsers/firefox.json#L609-L622

@queengooborg
Copy link
Contributor

We do keep data about beta and nightly releases around, but generally, I recommend adding data for final releases only.

@Constellation
Copy link
Contributor Author

OK, thanks!!!

sideshowbarker pushed a commit that referenced this pull request Nov 9, 2020
Based on discussion in #7248, we mark it as Safari 14 feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants