Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter to make sure statuses have consistent inheritance #7351

Closed
wants to merge 24 commits into from
Closed

Add linter to make sure statuses have consistent inheritance #7351

wants to merge 24 commits into from

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Nov 12, 2020 •
edited
Loading

A checklist to help your pull request get merged faster:

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG linter Issues or pull requests regarding the tests / linter of the JSON files. labels Nov 12, 2020
saschanaz
saschanaz commented Nov 12, 2020
View reviewed changes
html/elements/script.json Outdated Show resolved Hide resolved
api/WorkerGlobalScope.json Outdated Show resolved Hide resolved
api/UIEvent.json Outdated Show resolved Hide resolved
Base automatically changed from master to main March 24, 2021 12:54
@saschanaz saschanaz marked this pull request as ready for review October 2, 2021 23:37
@saschanaz saschanaz requested a review from ddbeck as a code owner October 2, 2021 23:37
foolip
foolip reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward, happy to review this to completion. In this cases the changes to the data are few enough that I think it's fine to do them in the same PR as the lint.

Do you think we should also lint for experimental status, that a non-experimental feature must have a non-experimental parent?

test/linter/test-status.js Outdated Show resolved Hide resolved
@foolip
Copy link
Contributor

foolip commented Apr 20, 2022

Right, also it shouldn't be possible to have a standard feature as a child of a non-standard feature. So all 3 statuses should be possible to have similar lints for.

@saschanaz saschanaz mentioned this pull request Apr 21, 2022
Merged
@saschanaz
Copy link
Contributor Author

Got a lot more after including experimental status check, so splitting this too.

@github-actions github-actions bot added the scripts Issues or pull requests regarding the scripts in scripts/. label Apr 21, 2022
@saschanaz saschanaz changed the title Add linter to make sure deprecated statuses are consistent Add linter to make sure statuses have consistent inheritance Apr 21, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@queengooborg
Copy link
Contributor

Looks like this needs to be formatted, could you run a formatter real quick to see what needs to be done to make this linter pass?

@saschanaz
Copy link
Contributor Author

(#15932 exists for this)

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@schalkneethling schalkneethling removed the request for review from ddbeck August 29, 2022 23:25
@github-actions github-actions bot removed rebase needed 🚧 dependencies Pull requests that update a dependency package or file. data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Nov 24, 2022
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request Nov 24, 2022
@saschanaz
Fix status inheritance inconsistency, round 2
d43bbcd 
From mdn#7351.
@saschanaz saschanaz mentioned this pull request Nov 24, 2022
Merged
foolip pushed a commit that referenced this pull request Nov 24, 2022
@saschanaz
Fix status inheritance inconsistency, round 2 (#18269)
129e780 
From #7351.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 24, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@saschanaz
Copy link
Contributor Author

I don't think I'll merge repeatedly only to be replaced by others, closing.

@saschanaz saschanaz closed this Feb 26, 2023
@saschanaz saschanaz deleted the lint-deprecated branch February 26, 2023 08:25
@Woodpile37 Woodpile37 mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. scripts Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a linter to make sure deprecated flag is also applied to children
4 participants
@saschanaz @foolip @queengooborg @ddbeck