Update IE data for HTML element APIs #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
reviewed
Nov 23, 2020
|
@vinyldarkscratch I see that changes remain for api.HTMLImageElement.lowSrc, api.HTMLInputElement.formEncType, and other miscapitalized APIs. Can you double check that all of the remaining changes are correct? |
foolip
approved these changes
Nov 24, 2020
api/HTMLElement.json
Outdated
| @@ -2356,7 +2356,7 @@ | |||
| "version_added": null | |||
| }, | |||
| "ie": { | |||
| "version_added": null | |||
| "version_added": false | |||
There was a problem hiding this comment.
I'm removing this entry in #7484, onModule isn't a thing.
| @@ -68,7 +68,7 @@ | |||
| "version_added": "4" | |||
| }, | |||
| "ie": { | |||
| "version_added": "10" | |||
| "version_added": "9" | |||
There was a problem hiding this comment.
This now matches the api.HTMLAudioElement entry itself, makes sense!
api/HTMLMenuElement.json
Outdated
| @@ -165,7 +165,7 @@ | |||
| "version_added": "8" | |||
| }, | |||
| "ie": { | |||
| "version_added": true | |||
| "version_added": "≤6" | |||
There was a problem hiding this comment.
This change seems a little bit suspect, why is only api.HTMLMenuElement.type updated but not the parent entry or api.HTMLMenuElement.compact? Don't the tests cover those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Internet Explorer data for various HTML element APIs based upon results from the mdn-bcd-collector project. Results were manually verified for confirmation.