Add real values for Firefox for Media APIs #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
foolip
reviewed
Nov 30, 2020
api/TextTrackCue.json
Outdated
| @@ -14,10 +14,10 @@ | |||
| "version_added": "≤79" | |||
| }, | |||
| "firefox": { | |||
| "version_added": null | |||
| "version_added": "42" | |||
There was a problem hiding this comment.
It is odd if TextTrackCue shipped after VTTCue, since VTTCue inherits from TextTrackCue. But TextTrackCue is an abstract interface, so it may in fact have happened.
Can you also update https://developer.mozilla.org/en-US/docs/Web/API/VTTCue as part of this, or better yet split out the text track-related stuff Text* and VTT* into a separate PR?
api/TextTrackList.json
Outdated
| @@ -14,10 +14,10 @@ | |||
| "version_added": "≤18" | |||
| }, | |||
| "firefox": { | |||
| "version_added": true | |||
| "version_added": "31" | |||
There was a problem hiding this comment.
Can you also update https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/textTracks to ensure that was also introduced in Firefox 31? If not there's something funny going on.
|
I got a notification for the PR update. For the avoidance of doubt, there are still a lot of outstanding issues. |
foolip
approved these changes
Dec 14, 2020
foolip
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds version numbers for Firefox for various Media APIs based upon results from the mdn-bcd-collector project, along with some mirroring. This PR is cherry-picked to APIs where the base version number is not adjusted.