-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove media members of HTMLAnchorElement/HTMLAreaElement #7538
Conversation
@@ -239,54 +239,6 @@ | |||
} | |||
} | |||
}, | |||
"media": { | |||
"__compat": { | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLAnchorElement/media", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/docs/Web/API/HTMLAnchorElement/media is 404 and I've already cleaned up https://developer.mozilla.org/docs/Web/API/HTMLAnchorElement
@@ -239,54 +239,6 @@ | |||
} | |||
} | |||
}, | |||
"media": { | |||
"__compat": { | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLAreaElement/media", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
404 and I've cleaned up https://wiki.developer.mozilla.org/en-US/docs/Web/API/HTMLAreaElement
These entries both come from wiki migration: mdn#1116 mdn#1119 These do not exist in the spec, a media IDL attribute exists only on these three interfaces: https://html.spec.whatwg.org/#htmllinkelement https://html.spec.whatwg.org/#htmlsourceelement https://html.spec.whatwg.org/#htmlstyleelement BCD already has entries for those. The existing data suggesting media is supported on a/area seems mistaken, and can be confirmed with these tests: http://mdn-bcd-collector.appspot.com/tests/api/HTMLAnchorElement/media http://mdn-bcd-collector.appspot.com/tests/api/HTMLAreaElement/media Both return false on Chrome 86, Edge 18, Firefox 82 and Safari 14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the wiki, this was initially documented in 2010, and the spec back then was https://www.w3.org/TR/2010/WD-html5-20100624/text-level-semantics.html#the-a-element where there is HTMLAnchorElement.media. However, I assume it got removed from the spec and wasn't really implemented? Anyway LGTM as it is gone from specs and implementations.
I tracked down the removal to whatwg/html@66fcb23 / https://www.w3.org/Bugs/Public/show_bug.cgi?id=20521 |
These entries both come from wiki migration:
#1116
#1119
These do not exist in the spec, a media IDL attribute exists only on
these three interfaces:
https://html.spec.whatwg.org/#htmllinkelement
https://html.spec.whatwg.org/#htmlsourceelement
https://html.spec.whatwg.org/#htmlstyleelement
BCD already has entries for those.
The existing data suggesting media is supported on a/area seems
mistaken, and can be confirmed with these tests:
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAnchorElement/media
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAreaElement/media
Both return false on Chrome 86, Edge 18, Firefox 82 and Safari 14.