Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove media members of HTMLAnchorElement/HTMLAreaElement #7538

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Nov 28, 2020

These entries both come from wiki migration:
#1116
#1119

These do not exist in the spec, a media IDL attribute exists only on
these three interfaces:
https://html.spec.whatwg.org/#htmllinkelement
https://html.spec.whatwg.org/#htmlsourceelement
https://html.spec.whatwg.org/#htmlstyleelement

BCD already has entries for those.

The existing data suggesting media is supported on a/area seems
mistaken, and can be confirmed with these tests:
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAnchorElement/media
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAreaElement/media

Both return false on Chrome 86, Edge 18, Firefox 82 and Safari 14.

@foolip foolip requested a review from Elchi3 November 28, 2020 18:14
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 28, 2020
@foolip foolip added needs-release-note 📰 and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Nov 28, 2020
@@ -239,54 +239,6 @@
}
}
},
"media": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLAnchorElement/media",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -239,54 +239,6 @@
}
}
},
"media": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLAreaElement/media",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 29, 2020
These entries both come from wiki migration:
mdn#1116
mdn#1119

These do not exist in the spec, a media IDL attribute exists only on
these three interfaces:
https://html.spec.whatwg.org/#htmllinkelement
https://html.spec.whatwg.org/#htmlsourceelement
https://html.spec.whatwg.org/#htmlstyleelement

BCD already has entries for those.

The existing data suggesting media is supported on a/area seems
mistaken, and can be confirmed with these tests:
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAnchorElement/media
http://mdn-bcd-collector.appspot.com/tests/api/HTMLAreaElement/media

Both return false on Chrome 86, Edge 18, Firefox 82 and Safari 14.
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the wiki, this was initially documented in 2010, and the spec back then was https://www.w3.org/TR/2010/WD-html5-20100624/text-level-semantics.html#the-a-element where there is HTMLAnchorElement.media. However, I assume it got removed from the spec and wasn't really implemented? Anyway LGTM as it is gone from specs and implementations.

@Elchi3 Elchi3 merged commit a945932 into mdn:master Nov 30, 2020
@foolip foolip deleted the rm-media branch November 30, 2020 15:00
@foolip
Copy link
Contributor Author

foolip commented Nov 30, 2020

I tracked down the removal to whatwg/html@66fcb23 / https://www.w3.org/Bugs/Public/show_bug.cgi?id=20521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants