Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update anchor and area support of target=_blank imply rel=noopener #7642

Merged
merged 6 commits into from
Dec 17, 2020
Merged

Update anchor and area support of target=_blank imply rel=noopener #7642

merged 6 commits into from
Dec 17, 2020

Conversation

mems
Copy link
Contributor

@mems mems commented Dec 11, 2020

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Dec 11, 2020
@ddbeck ddbeck self-requested a review December 13, 2020 12:53
ddbeck
ddbeck requested changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mems and thank you for this PR. I see this is your first to BCD—welcome to the project!

This change looks good, though it looks like this will make it to Edge 88 as well. Would you mind if we included Edge too? Line comments with suggestions.

html/elements/a.json Outdated Show resolved Hide resolved
html/elements/area.json Outdated Show resolved Hide resolved
@mems @ddbeck
Include support of implicit rel=noopener by Edge 88
9628fef 
Anchor and area target=_blank imply rel=noopener

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@mems
Copy link
Contributor Author

mems commented Dec 14, 2020

Thanks @ddbeck. I've added the Edge version too as suggested.

But the CI fail with the error:

Problems in 1 file:
✖ api/HTMLInputElement.json
  Style – 1 error:
  → Error on line #2699
    Actual:             "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLInputElement/width",
    Expected:           "support": {

Look like it's related to #7751

@queengooborg
Copy link
Contributor

queengooborg commented Dec 14, 2020 •
edited
Loading

Apologies for the failing CI -- I've merged a quick fix to resolve the build failures! Can you do a quick merge of the latest master?

@mems
Copy link
Contributor Author

mems commented Dec 14, 2020

@vinyldarkscratch Done. Thanks that solve it.

ddbeck
ddbeck approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mems! 🎉

@ddbeck ddbeck merged commit 4231a0e into mdn:master Dec 17, 2020
@kiding kiding mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome 88 supports implicit rel=noopener behavior
3 participants
@mems @queengooborg @ddbeck