Add Chromium versions for PluginArray API #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `PluginArray` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.6). Results are manually confirmed for accuracy. Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PluginArray
github-actions
bot
added
the
data:api
foolip
reviewed
Dec 17, 2020
api/PluginArray.json
Outdated
| @@ -23,10 +23,10 @@ | |||
| "version_added": null | |||
| }, | |||
| "opera": { | |||
| "version_added": true | |||
| "version_added": "15" | |||
There was a problem hiding this comment.
I wonder if this wasn't supported in Opera Presto. PluginArray is the type for navigator.plugins, can you update that entry at the same time and see if the values are the same? I suspect that the interface object just wasn't exposed, and that this needs to test an instance, which is simply navigator.plugins.
There was a problem hiding this comment.
Looks like this is a case of unexposed interface, you're right. Adding a custom test, and manually updated the data.
foolip
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
PluginArrayAPI, based upon results from the mdn-bcd-collector project (v1.1.6). Results are manually confirmed for accuracy.Additionally, this adjusts a note on a few methods to match our typical wording, and copies it to all of the Chrome-based browsers.
Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PluginArray