Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chromium versions for MediaQueryListEvent API #8433

Merged
merged 2 commits into from
Dec 30, 2020

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Dec 29, 2020

This PR adds real values for Chromium for the MediaQueryListEvent API, as well as corrects the WebView data, based upon commit history. Doing some digging around, I found that the API and all of its members were available since Chrome 39. Additionally, the API is not disabled in WebView, and considering the false values had come from the initial wiki migration, I'm led to simply disregard them.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 29, 2020
@foolip
Copy link
Contributor

foolip commented Dec 29, 2020

Chrome 45 cannot be trusted due to #7844. Can you check the time of the commit against https://www.chromium.org/developers/calendar to double check?

@foolip
Copy link
Contributor

foolip commented Dec 29, 2020

I agree that the WebView data here is very likely wrong, this is an API that doesn't require much in the way of platform integration.

@queengooborg queengooborg marked this pull request as draft December 29, 2020 16:53
@queengooborg queengooborg marked this pull request as draft December 29, 2020 16:53
@queengooborg queengooborg marked this pull request as draft December 29, 2020 16:53
@queengooborg
Copy link
Contributor Author

Hmm, yeah, the date suggests a much earlier version than 45. Marking as draft for now, will come back to this soon!

@queengooborg queengooborg marked this pull request as ready for review December 30, 2020 07:25
@queengooborg
Copy link
Contributor Author

Alrighty, this one's ready to go now! I checked the commit date and mapped it against the Chrome release concordance spreadsheet Joe had shared, comparing the feature freeze dates to the commit date, which puts the commit (Aug 30, 2014) to land in Chrome 39 (Sep 12, 2014). I then confirmed this via manual testing in BrowserStack.

@foolip
Copy link
Contributor

foolip commented Dec 30, 2020

Thanks @vinyldarkscratch!

@foolip foolip merged commit ab7827a into mdn:master Dec 30, 2020
@queengooborg queengooborg deleted the api/MediaQueryListEvent/chrome branch December 30, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants