Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename :-webkit-autofill to :autofill #8877

Merged
merged 4 commits into from
Feb 5, 2021
Merged

Conversation

rachelandrew
Copy link
Collaborator

Working on mdn/content#1725

Firefox has implemented :autofill adding the webkit prefixed version as an alias, as this is now part of a spec moving the property to the standard name with the webkit versions as prefixed versions.

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jan 27, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed to the Firefox data here. Thank you, @rachelandrew!

},
"firefox": {
"version_added": "86",
"notes": "Firefox has also implemented -webkit-autofill as an alias."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note should be reported as two support statements in an array, one with a prefix and one without.

},
"firefox_android": {
"version_added": "86",
"notes": "Firefox has also implemented -webkit-autofill as an alias."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, this note should be expressed as a separate support statement.

@ddbeck ddbeck changed the title moving webkit-autofill Rename :-webkit-autofill to :autofill Feb 4, 2021
@rachelandrew rachelandrew requested a review from ddbeck February 5, 2021 15:15
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rachelandrew! 🎉

@ddbeck ddbeck merged commit 0909cfb into mdn:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants