Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KeyboardEvent.DOM_KEY_* constants #9195

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Feb 19, 2021

These should be removed per the recent guideline on the matter:
https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#constants

These appear to be the last such constants in BCD.

These should be removed per the recent guideline on the matter:
https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#constants

These appear to be the last such constants in BCD.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 19, 2021
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mdn_urls also don't exist (we won't create pages for each constant either)

@Elchi3 Elchi3 merged commit a79b36b into mdn:master Feb 22, 2021
@foolip foolip deleted the rm-DOM_KEY branch February 22, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants