Add compat data for Response (Fetch API) #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmedley
suggested changes
Feb 5, 2018
api/Response.json
Outdated
| } | ||
| ], | ||
| "opera_android": { | ||
| "version_added": false |
There was a problem hiding this comment.
"opera_android" should match "opera".
Elchi3
added
the
data:api
Elchi3
requested changes
Feb 8, 2018
api/Response.json
Outdated
| "deprecated": false | ||
| } | ||
| }, | ||
| "body_formdata": { |
There was a problem hiding this comment.
Let's remove this. It is stored here https://github.com/mdn/browser-compat-data/blob/master/api/Body.json#L380
api/Response.json
Outdated
| } | ||
| } | ||
| }, | ||
| "redirected_attribute": { |
There was a problem hiding this comment.
Remove this, it is redundant with the entry for redirected below.
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
There was a problem hiding this comment.
"Experimental Web Platform Features"
api/Response.json
Outdated
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/Response", | ||
| "support": { | ||
| "webview_android": { |
There was a problem hiding this comment.
I think this should be
"webview_android": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
"chrome": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
"chrome_android": [
{
"version_added": "42"
},
{
"version_added": "41",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
],
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
There was a problem hiding this comment.
"Experimental Web Platform Features"
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
There was a problem hiding this comment.
"Experimental Web Platform Features"
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
There was a problem hiding this comment.
"Experimental Web Platform Features"
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
api/Response.json
Outdated
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "" |
There was a problem hiding this comment.
"Experimental Web Platform Features"
|
Should be good to go now! :) |
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Mar 8, 2021
There's no trace of this in Chromium, Gecko or WebKit, with no case-insensitive matches for "usefinalurl" at all. The closest thing is that there was once a TODO for `finalURL` in Blink which was removed: https://bugs.chromium.org/p/chromium/issues/detail?id=455112 This is from the initial wiki migration: mdn#940 The version numbers match the parent feature and many sibling features, and was probably copied.
ddbeck
pushed a commit
that referenced
this pull request
Mar 11, 2021
There's no trace of this in Chromium, Gecko or WebKit, with no case-insensitive matches for "usefinalurl" at all. The closest thing is that there was once a TODO for `finalURL` in Blink which was removed: https://bugs.chromium.org/p/chromium/issues/detail?id=455112 This is from the initial wiki migration: #940 The version numbers match the parent feature and many sibling features, and was probably copied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/Response