Set Attr and related APIs as supported since Safari 1 #9565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
The difference between Safari 1 and 1.3 is of course not important, but some assumption has to be made to fix localName/namespaceURI/prefix: mdn#9561 Based on current Web IDL, the set of related APIs are: - Document.createAttribute - Document.createAttributeNS - Element.attributes (a NamedNodeMap) - Element.getAttributeNode - Element.getAttributeNodeNS - Element.setAttributeNode - Element.setAttributeNodeNS - Element.removeAttributeNode - NamedNodeMap and all of its members All can be found in the bindings of the revision tagged Safari 85: https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/ecma/kjs_dom.lut.h?rev=4552 The only complication is Attr.localName/namespaceURI/prefix, which was then on Node, but judging by the implementation they probably worked: https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/dom/dom_node.cpp?rev=4552 Because some Element.* entries were set to 1, api.Element itself was also set to 1, and the following non-Attr-related features also confirmed to be in kjs_dom.lut.h above: - Element.getAttribute - Element.getAttributeNS - Element.getElementsByTagName - Element.getElementsByTagNameNS - Element.hasAttribute - Element.hasAttributeNS - Element.hasAttributes (on Node) - Element.removeAttribute - Element.removeAttributeNS - Element.scrollLeft (on Node) - Element.scrollTop (on Node) - Element.scrollHeight (on Node) - Element.scrollWidth (on Node) - Element.setAttribute - Element.setAttributeNS - Element.tagName Finally, Element.className and id were here: https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/ecma/kjs_html.lut.h?rev=4552
Elchi3
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between Safari 1 and 1.3 is of course not important, but
some assumption has to be made to fix localName/namespaceURI/prefix:
#9561
Based on current Web IDL, the set of related APIs are:
All can be found in the bindings of the revision tagged Safari 85:
https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/ecma/kjs_dom.lut.h?rev=4552
The only complication is Attr.localName/namespaceURI/prefix, which was
then on Node, but judging by the implementation they probably worked:
https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/dom/dom_node.cpp?rev=4552
Because some Element.* entries were set to 1, api.Element itself was
also set to 1, and the following non-Attr-related features also
confirmed to be in kjs_dom.lut.h above:
Finally, Element.className and id were here:
https://trac.webkit.org/browser/webkit/trunk/WebCore/khtml/ecma/kjs_html.lut.h?rev=4552