Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete api/DOMHighResTimestamp.json #9892

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Delete api/DOMHighResTimestamp.json #9892

merged 2 commits into from
Apr 29, 2021

Conversation

bershanskiy
Copy link
Contributor

@bershanskiy bershanskiy commented Apr 16, 2021

This interface is officially called DOMHighResTimeStamp.

Specification:
https://www.w3.org/TR/hr-time-2/#dom-domhighrestimestamp
Firefox source:
https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/Performance.webidl
WebKit source:
https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/PerformanceResourceTiming.idl
Chromium:
https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/core/timing/dom_high_res_time_stamp.idl

Edit: removed unnecessary reference to another bug.

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 16, 2021
@foolip
Copy link
Contributor

foolip commented Apr 16, 2021

This is a curious case. I agree with matching the spec, but I wonder if this should really be in MDN and BCD.

This is a typedef (alias) for double, so it's a bit like saying that JS Number is supported, which it was since before the typedef was conceived of.

@ddbeck @Elchi3 like mixins and partials this is a spec writer convenience, should we remove it?

@Elchi3
Copy link
Member

Elchi3 commented Apr 19, 2021

Yeah, not sure types need compat data. It seems similar to what we said about constants: usually, there is no compat story to tell. The MDN page seems worthwhile so that people know what this type is, though. However, it could be a glossary page or something more light.

@foolip
Copy link
Contributor

foolip commented Apr 19, 2021

Constants are at least visible, NodeFilter.SHOW_ATTRIBUTE can be inspected (the value 2) and used as an argument for document.createNodeIterator(). By contrast, the string "DOMHighResTimeStamp" would never show up in JavaScript.

But that's all good, if constants were obscure enough to omit then typedefs must be too. I'll file an issue.

@foolip foolip mentioned this pull request Apr 19, 2021
@bershanskiy bershanskiy changed the title Rename DOMHighResTimestamp to DOMHighResTimeStamp Delete api/DOMHighResTimestamp.json Apr 19, 2021
@bershanskiy
Copy link
Contributor Author

Given discussion above, deleting this file maks more sense.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 3065760 into mdn:main Apr 29, 2021
@bershanskiy bershanskiy deleted the breaking-rename-DOMHighResTimeStamp branch April 29, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants