-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XRSystem: Single page for devicechange event #10474
Conversation
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLsURL: No new external URLs URL: No new external URLs (this comment was updated 2021-11-18 13:51:03.609346) |
|
||
## Event type | ||
|
||
{{DOMxRef("Event")}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I'm not very keen on this way of representing the event type. Is this an an H2 section that's only ever going to contain one word? I think I liked the table we had before better. Similarly, if we want to represent "cancelable" in a consistent way, isn't it better in a table than in prose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of "Event type" analog to "Return value" in method pages, but maybe it should be an h3 under Syntax then?
I'm not yet sure about cancelable and if it is all that important. So far it has always been "no".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started https://github.com/mdn/content/discussions/10544 so we can discuss the new event page type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a commit that experiments with no syntax section but h3 headings for Trigger, Event type and Use cases.
Summary
Have one page for the
device change
event ofXRSystem
. Redirect theondevicechange
event handler page to it.Motivation
De-duplicated event pages.