Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRSystem: Single page for devicechange event #10474

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 12, 2021

Summary

Have one page for the device change event of XRSystem. Redirect the ondevicechange event handler page to it.

Motivation

De-duplicated event pages.

@Elchi3 Elchi3 requested review from a team as code owners November 12, 2021 11:33
@Elchi3 Elchi3 requested review from ddbeck and sideshowbarker and removed request for a team November 12, 2021 11:33
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/XRSystem
Title: XRSystem
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/XRSystem
Title: XRSystem
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/XRSystem/devicechange_event
Title: XRSystem: devicechange event
on GitHub

No new external URLs

(this comment was updated 2021-11-18 13:51:03.609346)


## Event type

{{DOMxRef("Event")}}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I'm not very keen on this way of representing the event type. Is this an an H2 section that's only ever going to contain one word? I think I liked the table we had before better. Similarly, if we want to represent "cancelable" in a consistent way, isn't it better in a table than in prose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of "Event type" analog to "Return value" in method pages, but maybe it should be an h3 under Syntax then?
I'm not yet sure about cancelable and if it is all that important. So far it has always been "no".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started https://github.com/mdn/content/discussions/10544 so we can discuss the new event page type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a commit that experiments with no syntax section but h3 headings for Trigger, Event type and Use cases.

@sideshowbarker sideshowbarker merged commit efcaf98 into mdn:main Nov 19, 2021
@Elchi3 Elchi3 deleted the xrsystem-event branch November 22, 2021 08:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants