Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WakeLockSentinel: onrelease -> release event #10925

Merged
merged 2 commits into from
Dec 3, 2021
Merged

WakeLockSentinel: onrelease -> release event #10925

merged 2 commits into from
Dec 3, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 2, 2021

Have a release_event page instead of onrelease.

BCD work: mdn/browser-compat-data#13816

@Elchi3 Elchi3 requested review from a team as code owners December 2, 2021 17:24
@Elchi3 Elchi3 requested review from ddbeck and sideshowbarker and removed request for a team December 2, 2021 17:24
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 2, 2021
@Elchi3 Elchi3 mentioned this pull request Dec 2, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/API/WakeLockSentinel
Title: WakeLockSentinel
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/WakeLockSentinel/release_event
Title: WakeLockSentinel: release event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.WakeLockSentinel.release_event

External URLs

URL: /en-US/docs/Web/API/WakeLockSentinel
Title: WakeLockSentinel
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/WakeLockSentinel/release_event
Title: WakeLockSentinel: release event
on GitHub

No new external URLs

(this comment was updated 2021-12-03 05:04:36.130254)

@sideshowbarker sideshowbarker merged commit 695918f into mdn:main Dec 3, 2021
@Elchi3 Elchi3 deleted the events-wakelocksentinel branch December 4, 2021 17:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@ddbeck ddbeck Awaiting requested review from ddbeck ddbeck is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @sideshowbarker