Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly mark Warning HTTP-Header as deprecated #11079

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Properly mark Warning HTTP-Header as deprecated #11079

merged 2 commits into from
Dec 9, 2021

Conversation

DerZade
Copy link
Contributor

@DerZade DerZade commented Dec 9, 2021

Summary

This PR will properly mark the Warning HTTP-Header as deprecated.

Motivation

The page of the Warning-Header already states it is deprecated. It was just not properly marked as deprecated.

Supporting details

httpwg/http-core#139
whatwg/fetch#913

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@DerZade DerZade requested a review from a team as a code owner December 9, 2021 13:27
@DerZade DerZade requested review from teoli2003 and removed request for a team December 9, 2021 13:27
@github-actions github-actions bot added the Content:HTTP HTTP docs label Dec 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTTP/Headers
Title: HTTP headers
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Warning
Title: Warning
on GitHub

No new external URLs

hamishwillee
hamishwillee approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thanks. I removed the manual note below and I'll also open a browser compatibility entry to mark this deprecated in the table at the bottom.

@hamishwillee hamishwillee merged commit c71fd9d into mdn:main Dec 9, 2021
@hamishwillee hamishwillee mentioned this pull request Dec 10, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:HTTP HTTP docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerZade @hamishwillee