Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS color-adjust renamed to print-color-adjust #12524

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jan 31, 2022

This is part of FF97 release work documented in #11598. It covers the release note, moving the document, and fixing up mentions.

Note, extra BCD work done in mdn/browser-compat-data#14738

@hamishwillee hamishwillee requested review from a team as code owners January 31, 2022 04:18
@hamishwillee hamishwillee requested review from rachelandrew, ericwbailey and ddbeck and removed request for a team January 31, 2022 04:18
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label labels Jan 31, 2022
@@ -66,6 +66,6 @@ Not part of any standard, though there is a [proposal in the CSSWG wiki](https:/

## See also

- {{cssxref("print-color-adjust")}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rumyra This is an old pre-standard version of the name. It is captured in BCD. For now all I have done is link to the actual standardized version. However IMO it might be better to delete this altogether. Any reason why not? [I would do as a post process)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh that sounds good to me @hamishwillee 👍

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/97
Title: Firefox 97 for developers
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/@scroll-timeline does not exist

URL: /en-US/docs/Web/HTML/Applying_color
Title: Applying color to HTML elements using CSS
on GitHub
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/CSS/CSS_Color
Title: CSS Color
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.properties.print-color-adjust

URL: /en-US/docs/Web/CSS/color
Title: color
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/currentcolor redirects to /en-US/docs/Web/CSS/color_value#currentcolor_keyword
  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/CSS/WebKit_Extensions
Title: WebKit CSS extensions
on GitHub
Flaw count: 93

  • macros:
    • /en-US/docs/Web/CSS/-webkit-animation-trigger does not exist
    • /en-US/docs/Web/CSS/-webkit-app-region does not exist
    • /en-US/docs/Web/CSS/-webkit-aspect-ratio does not exist
    • /en-US/docs/Web/CSS/-webkit-backdrop-filter does not exist
    • /en-US/docs/Web/CSS/-webkit-background-composite does not exist
    • and 88 more flaws omitted

URL: /en-US/docs/Web/CSS/print-color-adjust
Title: print-color-adjust
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: css.properties.print-color-adjust

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/97
Title: Firefox 97 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Applying_color
Title: Applying color to HTML elements using CSS
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/color-scheme
Title: color-scheme
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/forced-color-adjust
Title: forced-color-adjust
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/CSS_Color
Title: CSS Color
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/color
Title: color
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/WebKit_Extensions
Title: WebKit CSS extensions
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/print-color-adjust
Title: print-color-adjust
on GitHub

No new external URLs

(this comment was updated 2022-01-31 23:35:56.507524)

@hamishwillee
Copy link
Collaborator Author

@Rumyra OK, conflict removed. I also deleted the -webkit-page-color-adjust page as discussed. Ready for review/merge.

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 1, 2022

Brill - thanks @hamishwillee

@Rumyra Rumyra merged commit 008f3fb into mdn:main Feb 1, 2022
@hamishwillee hamishwillee deleted the printcoladjust branch February 3, 2022 23:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants