Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page: radiogroup role #12573

Merged
merged 17 commits into from
Mar 13, 2022
Merged

New page: radiogroup role #12573

merged 17 commits into from
Mar 13, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 1, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner February 1, 2022 03:52
@estelle estelle requested review from ericwbailey and removed request for a team February 1, 2022 03:52
@estelle estelle marked this pull request as draft February 1, 2022 03:52
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 1, 2022
@estelle estelle mentioned this pull request Feb 1, 2022
Closed
42 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/web/accessibility/aria/roles/radiogroup_role
Title: aria: radiogroup role
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /Web/HTML/Global_attributes/tabindex

External URLs

URL: /en-US/docs/web/accessibility/aria/roles/radiogroup_role
Title: aria: radiogroup role
on GitHub

(this comment was updated 2022-03-08 03:17:09.032623)

@estelle estelle changed the title DRAFT: New page: radiogroup role New page: radiogroup role Feb 1, 2022
@estelle estelle marked this pull request as ready for review February 1, 2022 21:20
ericwbailey
ericwbailey suggested changes Feb 6, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requests here, and a third apology for the delay 😓

files/en-us/web/accessibility/aria/roles/radiogroup_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/radiogroup_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/radiogroup_role/index.md Outdated Show resolved Hide resolved
@estelle estelle enabled auto-merge (squash) March 8, 2022 03:24
scottaohara
scottaohara reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@estelle estelle merged commit 7378bd3 into mdn:main Mar 13, 2022
@estelle estelle deleted the radiogroup branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@ericwbailey ericwbailey ericwbailey approved these changes

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @ericwbailey @scottaohara