Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VideoTrackList for new-style event pages #12597

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 1, 2022

This PR updates VideoTrackList for new-style event pages. (see the template)

To deduplicate the pages, I used these commands:

yarn content delete Web/API/VideoTrackList/onaddtrack --redirect=/en-US/docs/Web/API/VideoTrackList/addtrack_event
yarn content delete Web/API/VideoTrackList/onremovetrack --redirect=/en-US/docs/Web/API/VideoTrackList/removetrack_event
yarn content delete Web/API/VideoTrackList/onchange --redirect=/en-US/docs/Web/API/VideoTrackList/change_event  

BCD is approved in mdn/browser-compat-data#13885

@Elchi3 Elchi3 requested review from a team as code owners February 1, 2022 17:39
@Elchi3 Elchi3 requested review from Rumyra and removed request for a team February 1, 2022 17:39
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/VideoTrackList
Title: VideoTrackList
on GitHub
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

External URLs

URL: /en-US/docs/Web/API/VideoTrackList
Title: VideoTrackList
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VideoTrackList/addtrack_event
Title: VideoTrackList: addtrack event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VideoTrackList/removetrack_event
Title: VideoTrackList: removetrack event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/VideoTrackList/change_event
Title: VideoTrackList: change event
on GitHub

No new external URLs

(this comment was updated 2022-02-03 12:48:10.828967)

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two open questions, else it looks good.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "or null" to be removed twice and we are good to go.

@teoli2003 teoli2003 merged commit 1263cea into mdn:main Feb 3, 2022
@Elchi3 Elchi3 deleted the events-videotracklist branch February 3, 2022 12:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants