Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-break links to now-gone SpiderMonkey docs #12748

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Un-break links to now-gone SpiderMonkey docs #12748

merged 1 commit into from
Feb 5, 2022

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #12743

This fixes broken links to the now-gone /en-US/docs/Mozilla/Projects/SpiderMonkey by doing two things:

  • Remove from docs in the web/javascript/reference subtree any inline references to SpiderMonkey-specific behavior (not sure if that info is still up to date with current SpiderMonkey — and even if it is, that info belongs in BCD rather inlined in MDN content).

  • Replace links to /en-US/docs/Mozilla/Projects/SpiderMonkey in the en-us/mdn/guidelines/does_this_belong_on_mdn, en-us/mozilla/firefox/releases, and /en-us/tools docs with links to https://firefox-source-docs.mozilla.org/js/.

@sideshowbarker sideshowbarker requested review from a team as code owners February 5, 2022 07:57
@sideshowbarker sideshowbarker requested review from Elchi3 and removed request for a team February 5, 2022 07:57
@github-actions github-actions bot added Content:DevTools Firefox DevTools docs (retired) Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label labels Feb 5, 2022
@sideshowbarker sideshowbarker mentioned this pull request Feb 5, 2022
Closed
@sideshowbarker sideshowbarker requested review from teoli2003 and removed request for a team February 5, 2022 07:58
teoli2003
teoli2003 approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 56bc2d2 into main Feb 5, 2022
@teoli2003 teoli2003 deleted the sideshowbarker/SpiderMonkey-links-unbreak branch February 5, 2022 07:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

Preview URLs

Flaws

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub
Flaw count: 21

  • macros:
    • /en-US/docs/Web/CSS/-moz-math-display does not exist
    • /en-US/docs/Web/CSS/-moz-window-shadow does not exist
    • /en-US/docs/Web/CSS/@page/marks does not exist
    • /en-US/docs/Web/CSS/page does not exist
    • /en-US/docs/Web/CSS/size does not exist
    • and 11 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Firefox_for_Android/API/Snackbars.jsm
    • Can't resolve /en-US/docs/Mozilla/Firefox_for_Android
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/cfx
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/jpm
    • Can't resolve /en-US/docs/Mozilla/Add-ons/SDK/Tools/cfx_to_jpm

URL: /en-US/docs/Tools/Performance/Waterfall
Title: Waterfall
on GitHub
Flaw count: 3

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Tools/Performance/Allocations
Title: Allocations
on GitHub
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/MDN/Guidelines/Does_this_belong_on_MDN
Title: Does this belong on MDN Web Docs?
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Developer_guide/Build_Instructions
    • Can't resolve /en-US/docs/Mozilla/Gecko

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Tools/Memory/Tree_map_view
Title: Tree map view
on GitHub

URL: /en-US/docs/Tools/Performance/Waterfall
Title: Waterfall
on GitHub

URL: /en-US/docs/Tools/Performance/Allocations
Title: Allocations
on GitHub

URL: /en-US/docs/Tools/Debugger-API/Debugger.Memory
Title: Debugger.Memory
on GitHub

URL: /en-US/docs/Tools/Debugger-API/Debugger.Object
Title: Debugger.Object
on GitHub

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Property_Accessors
Title: Property accessors
on GitHub

No external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/URIError
Title: URIError
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError
Title: TypeError
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/message
Title: Error.prototype.message
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toDateString
Title: Date.prototype.toDateString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toTimeString
Title: Date.prototype.toTimeString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError
Title: SyntaxError
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError
Title: ReferenceError
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/EvalError
Title: EvalError
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/RangeError
Title: RangeError
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Guidelines/Does_this_belong_on_MDN
Title: Does this belong on MDN Web Docs?
on GitHub

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-javascript

Assignees
No one assigned
Labels
Content:DevTools Firefox DevTools docs (retired) Content:JS JavaScript docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "SyntaxError": dead link for 'SpiderMonkey'
2 participants
@sideshowbarker @teoli2003