Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Animation events to new structure #12882

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Feb 10, 2022

This PR updates the Animation interface for new-style event pages. (see the template)

The on-* event handler pages are redirected to the eventname_event pages.

yarn content move Web/API/Animation/oncancel Web/API/Animation/cancel_event
yarn content move Web/API/Animation/onfinish Web/API/Animation/finish_event
yarn content move Web/API/Animation/onremove Web/API/Animation/remove_event

BCD: mdn/browser-compat-data#14914

@teoli2003 teoli2003 requested a review from Elchi3 February 10, 2022 09:23
@teoli2003 teoli2003 requested review from a team as code owners February 10, 2022 09:23
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

Preview URLs

Flaws

Note! 20 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Animation
Title: Animation
on GitHub
Flaw count: 3

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Animation/remove_event
Title: Animation: remove event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Animation.remove_event

URL: /en-US/docs/Web/API/Animation/startTime
Title: Animation.startTime
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Timeline does not exist
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/Animation/cancel_event
Title: Animation: cancel event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Animation.cancel_event

URL: /en-US/docs/Web/API/Animation/finish_event
Title: Animation: finish event
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Animation.finish_event

External URLs

URL: /en-US/docs/Web/API/Animation
Title: Animation
on GitHub


URL: /en-US/docs/Web/API/Animation/remove_event
Title: Animation: remove event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/playbackRate
Title: Animation.playbackRate
on GitHub


URL: /en-US/docs/Web/API/Animation/effect
Title: Animation.effect
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/reverse
Title: Animation.reverse()
on GitHub


URL: /en-US/docs/Web/API/Animation/pending
Title: Animation.pending
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/ready
Title: Animation.ready
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/finish
Title: Animation.finish()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/id
Title: Animation.id
on GitHub


URL: /en-US/docs/Web/API/Animation/play
Title: Animation.play()
on GitHub


URL: /en-US/docs/Web/API/Animation/pause
Title: Animation.pause()
on GitHub


URL: /en-US/docs/Web/API/Animation/updatePlaybackRate
Title: Animation.updatePlaybackRate()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/currentTime
Title: Animation.currentTime
on GitHub


URL: /en-US/docs/Web/API/Animation/Animation
Title: Animation()
on GitHub


URL: /en-US/docs/Web/API/Animation/playState
Title: Animation.playState
on GitHub


URL: /en-US/docs/Web/API/Animation/commitStyles
Title: Animation.commitStyles()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/replaceState
Title: Animation.replaceState
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/startTime
Title: Animation.startTime
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/timeline
Title: Animation.timeline
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/cancel_event
Title: Animation: cancel event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/finished
Title: Animation.finished
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/cancel
Title: Animation.cancel()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/finish_event
Title: Animation: finish event
on GitHub


URL: /en-US/docs/Web/API/Animation/persist
Title: Animation.persist()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AnimationPlaybackEvent
Title: AnimationPlaybackEvent
on GitHub

No new external URLs

(this comment was updated 2022-02-10 12:19:49.409805)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some change requests but looks good overall.

Aside: I see a lot of whitespace changes... I thought we updated many files recently to fix these things. Is something wrong with your editor settings or has mdn/content's editorconfig changed or something?

oncancel = event => { }
```

### Value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "Value" section is not in the template. I don't think it is useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot this one.

files/en-us/web/api/animation/remove_event/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/animation/remove_event/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/animation/cancel_event/index.md Outdated Show resolved Hide resolved
teoli2003 and others added 4 commits February 10, 2022 12:44
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@teoli2003
Copy link
Contributor Author

Thanks, some change requests but looks good overall.

Aside: I see a lot of whitespace changes... I thought we updated many files recently to fix these things. Is something wrong with your editor settings or has mdn/content's editorconfig changed or something?

I modified them: they were unicode non-breakable spaces and I just replaced them with regular spaces. Some editors put them all over the place when you create new pages. (I think mainly Microsoft Word).

@teoli2003 teoli2003 requested a review from Elchi3 February 10, 2022 12:31
@Elchi3 Elchi3 merged commit 4f64c18 into mdn:main Feb 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants