-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Animation
events to new structure
#12882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some change requests but looks good overall.
Aside: I see a lot of whitespace changes... I thought we updated many files recently to fix these things. Is something wrong with your editor settings or has mdn/content's editorconfig changed or something?
oncancel = event => { } | ||
``` | ||
|
||
### Value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "Value" section is not in the template. I don't think it is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry forgot this one.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
I modified them: they were unicode non-breakable spaces and I just replaced them with regular spaces. Some editors put them all over the place when you create new pages. (I think mainly Microsoft Word). |
This PR updates the
Animation
interface for new-style event pages. (see the template)The
on-*
event handler pages are redirected to theeventname_event
pages.yarn content move Web/API/Animation/oncancel Web/API/Animation/cancel_event
yarn content move Web/API/Animation/onfinish Web/API/Animation/finish_event
yarn content move Web/API/Animation/onremove Web/API/Animation/remove_event
BCD: mdn/browser-compat-data#14914