Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Element fullscreen events to new structure #12931

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Adapt Element fullscreen events to new structure #12931

merged 1 commit into from
Feb 12, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR updates the fullscreenchange and fullscreenerror events of the Element API to conform to the new style. Additionally, this performs some updates to data for the Document API's events to make the two articles more similar to each other (since they already are so similar).

BCD PR: mdn/browser-compat-data#14944

@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub
Flaw count: 9

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Element/getBoxQuads does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onshow does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-valueMax
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-valueMin
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-valueNow
  • bad_bcd_links:
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 49

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/Document/afterscriptexecute_event does not exist
    • /en-US/docs/Web/API/Document/beforescriptexecute_event does not exist
    • /en-US/docs/Web/API/Document/oncopy does not exist
    • /en-US/docs/Web/API/Document/oncut does not exist
    • and 20 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document_Object_Model/Using_the_W3C_DOM_Level_1_Core
    • Can't resolve /en-US/docs/XUL_Overlays
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 17 more flaws omitted

URL: /en-US/docs/Web/API/Fullscreen_API
Title: Fullscreen API
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Web/API/Element
Title: Element
on GitHub


URL: /en-US/docs/Web/API/Element/fullscreenchange_event
Title: Element: fullscreenchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/fullscreenerror_event
Title: Element: fullscreenerror event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document
Title: Document
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/fullscreenchange_event
Title: Document: fullscreenchange event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Document/fullscreenerror_event
Title: Document: fullscreenerror event
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Fullscreen_API
Title: Fullscreen API
on GitHub

@sideshowbarker sideshowbarker merged commit cff65b4 into mdn:main Feb 12, 2022
@queengooborg queengooborg deleted the api/Element/fullscreen_events branch February 12, 2022 01:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants