-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt BatteryManager events to the new event structure #13021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Elchi3
requested changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I just found some nits
files/en-us/web/api/batterymanager/chargingchange_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/batterymanager/chargingchange_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/batterymanager/dischargingtimechange_event/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Elchi3
approved these changes
Feb 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
BroadcastChannel
interface for new-style event pages. (see the template).As
onXYZ
exists andXYZ_event
not, for eachonXYZ
yarn content move /Web/API/xxxx/onXYZ /Web/API/xxxx/XYZ_event
browser-compat
front-runner keytitle
front-runner key to:Interface: XYZ event
(with ticks!)Property
andEvent Handler
from the tag list and addEvent
instead (more cleaning possible)onXYZ
.onXYZ
propertyEvent type
section (two texts possible! If inheritance is not onlyEvent
, do these additional steps:{{InheritanceDiagram}}
Event properties
section and list the parameters, taken from the interface of the event typeonXYZ
is a link.onXYZ
is a link to the adequateXYZ_event
On the API interface page:
On each page of the interface and the API overview page:
onXYZ
.onXYZ = event => { …}
){{event}
macro is left.Optional:
Administration:
BCD: mdn/browser-compat-data#14993