Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major update: searchbox role #13141

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Major update: searchbox role #13141

merged 5 commits into from
Apr 6, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 20, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner February 20, 2022 02:19
@estelle estelle requested review from ericwbailey and removed request for a team February 20, 2022 02:19
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/searchbox_role
Title: ARIA: searchbox role
on GitHub

No new external URLs

(this comment was updated 2022-04-05 00:36:11.154391)

@estelle estelle mentioned this pull request Feb 23, 2022
Closed
42 tasks
ericwbailey
ericwbailey previously requested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little request, just a sentence explaining why the searchbox role should not be used with combobox.

files/en-us/web/accessibility/aria/roles/searchbox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/searchbox_role/index.md Outdated Show resolved Hide resolved
@estelle estelle requested a review from ericwbailey April 5, 2022 00:34
@estelle estelle dismissed ericwbailey’s stale review April 6, 2022 21:39

it was updated but is showing as if it weren't.

wbamberg
wbamberg approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks like Eric's comments here are addressed.

@wbamberg wbamberg merged commit bfbaed3 into mdn:main Apr 6, 2022
@estelle estelle deleted the searchbox branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @wbamberg @ericwbailey