Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: ARIA elements with only presentational descendants #13164

Merged
merged 5 commits into from
Mar 1, 2022
Merged

Update: ARIA elements with only presentational descendants #13164

merged 5 commits into from
Mar 1, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 21, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

There are some types of user interface components that, when represented in a platform accessibility API, can only contain text. For example, accessibility APIs do not have a way of representing semantic elements contained in a button. To deal with this limitation, WAI-ARIA requires browsers to automatically apply role presentation to all descendant elements of any element with a role that cannot support semantic children.

The roles that require all children to be presentational are:

button
checkbox
img
meter
menuitemcheckbox
menuitemradio
option
progressbar
radio
scrollbar
separator
slider
switch
tab

This PR adds that information to (most of) the above roles.

menuitemcheckbox, menuitemradio, and scrollbar are not included in this PR as they are currently being worked on under other PRs: openwebdocs/project#82

@estelle estelle requested a review from a team as a code owner February 21, 2022 01:03
@estelle estelle requested review from ericwbailey and removed request for a team February 21, 2022 01:03
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/img_role
Title: ARIA: img role
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/HTML/Element/svg does not exist
    • /en-US/docs/Web/HTML/Element/svg does not exist

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/slider_role
Title: ARIA: slider role
on GitHub
Flaw count: 2

  • broken_links:
    • Anchor not lowercase
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/spinbutton_role

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/progressbar_role
Title: ARIA: progressbar role
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/spinbutton_role

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/radio_role
Title: ARIA: radio role
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_role
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_Role#Keyboard_interactions
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_role

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/tab_role
Title: ARIA: tab role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role
Title: ARIA: checkbox role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/img_role
Title: ARIA: img role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/slider_role
Title: ARIA: slider role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/separator_role
Title: ARIA: separator role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/button_role
Title: ARIA: button role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/switch_role
Title: ARIA: switch role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/progressbar_role
Title: ARIA: progressbar role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/radio_role
Title: ARIA: radio role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/meter_role
Title: ARIA: meter role
on GitHub

No new external URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/option_role
Title: ARIA: option role
on GitHub

No new external URLs

(this comment was updated 2022-02-23 23:07:21.027094)

@estelle estelle mentioned this pull request Feb 23, 2022
Closed
42 tasks
estelle
estelle commented Feb 23, 2022
View reviewed changes
files/en-us/web/accessibility/aria/roles/button_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/checkbox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/img_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/meter_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/option_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/radio_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/separator_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/slider_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/switch_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/tab_role/index.md Outdated Show resolved Hide resolved
ericwbailey
ericwbailey approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is lovely. Thank you 🙂

@ericwbailey ericwbailey merged commit 9ac6b78 into mdn:main Mar 1, 2022
@estelle estelle deleted the presentKids branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwbailey ericwbailey ericwbailey approved these changes

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @ericwbailey