Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major update: scrollbar role #13245

Merged
merged 12 commits into from
Mar 31, 2022
Merged

Major update: scrollbar role #13245

merged 12 commits into from
Mar 31, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 24, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner February 24, 2022 05:32
@estelle estelle requested review from ericwbailey and removed request for a team February 24, 2022 05:32
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 24, 2022
@estelle estelle marked this pull request as draft February 24, 2022 05:32
@estelle estelle mentioned this pull request Feb 24, 2022
Closed
42 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/scrollbar_role
Title: ARIA: scrollbar role
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Roles/spinbutton_role

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/scrollbar_role
Title: ARIA: scrollbar role
on GitHub

(this comment was updated 2022-03-29 19:34:30.551264)

@estelle estelle changed the title DRAFT: Major update: scrollbar role Major update: scrollbar role Feb 26, 2022
@estelle estelle marked this pull request as ready for review February 26, 2022 03:43
ericwbailey
ericwbailey suggested changes Mar 1, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for updating the non-ARIA example to be fully accessible.

files/en-us/web/accessibility/aria/roles/scrollbar_role/index.md Outdated Show resolved Hide resolved
ericwbailey
ericwbailey approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ericwbailey ericwbailey merged commit 0eaf61d into mdn:main Mar 31, 2022
@estelle estelle deleted the scroolbar branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwbailey ericwbailey ericwbailey approved these changes

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @ericwbailey