-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt api.Document.pointerlock[change/error] to new events structure #13660
Conversation
This PR adapts the pointerlockchange and pointerlockerror event of the Document API to conform to the new events structure.
Preview URLs
FlawsNone! 🎉 External URLsURL: No new external URLs URL: No new external URLs |
[REVIEW IN PROGRESS] Checklist I used for reviewing this event Content PR: When
On the API interface page:
On each page of the interface and the API overview page:
Optional:
Administration:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments in the text (as the original page was incorrectly claiming these events bubbled, the new version don't say it)
<tbody> | ||
<tr> | ||
<th scope="row">Bubbles</th> | ||
<td>Yes</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this was incorrect: pointerlockerror
doesn't bubble. (See https://w3c.github.io/pointerlock/#pointerlockchange-and-pointerlockerror-events )
<tbody> | ||
<tr> | ||
<th scope="row">Bubbles</th> | ||
<td>Yes</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this was incorrect: pointerlockchange
doesn't bubble. (See https://w3c.github.io/pointerlock/#pointerlockchange-and-pointerlockerror-events )
This PR adapts the pointerlockchange and pointerlockerror event of the Document API to conform to the new events structure.