Major revision: tabpanel role #13743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
estelle
commented
Mar 10, 2022
estelle
commented
- Adds a new document
- Rewrites (or significantly expands) a document
- Fixes a typo, bug, or other error
42 tasks
Preview URLsFlawsURL:
External URLsURL:
(this comment was updated 2022-03-22 00:50:45.719594) |
estelle
changed the title
ericwbailey
suggested changes
Mar 22, 2022
files/en-us/web/accessibility/aria/roles/tabpanel_role/index.md
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
24
| Tabs do not act as anchor links to individual panels. While semantic HTML may be coded with the tabs being anchor links natigating to the tab's associated tabpanel, when JavaScript is used to progressively enhance the content to a tabbed interface, the link's default behavior should be prevented. | ||
|
|
There was a problem hiding this comment.
Suggested change
| Tabs do not act as anchor links to individual panels. While semantic HTML may be coded with the tabs being anchor links natigating to the tab's associated tabpanel, when JavaScript is used to progressively enhance the content to a tabbed interface, the link's default behavior should be prevented. |
files/en-us/web/accessibility/aria/roles/tabpanel_role/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/accessibility/aria/roles/tabpanel_role/index.md
Outdated
Show resolved
Hide resolved
| Hide the non-visible tabpanels that are not currently relevant with the HTML {{htmlattrxref('hidden')}} attribute or set [`aria-hidden="true"`](/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-labelledby). Browsers won't render elements with the `hidden` attribute set. If using `aria-hidden`, use CSS to hide the hidden tab panels. | ||
| The newly selected `tab` is considered "active" and should have it`s [`aria-selected`](/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-selected) attribute set to `true` while all other tabs in the same `tablist` should have the `aria-selected` attribute set to `false`, or removed altogether. See [ARIA `tab` role](/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role) for move information. | ||
|
|
||
| If the `tablist` precedes the `tabpanel` in source order, the user will expect to be able to step through the remaining tabs in focus order or select the <kbd>down arrow</kbd> to give focus to the visible tabpanel when navigating by keyboard. |
There was a problem hiding this comment.
Suggested change
| If the `tablist` precedes the `tabpanel` in source order, the user will expect to be able to step through the remaining tabs in focus order or select the <kbd>down arrow</kbd> to give focus to the visible tabpanel when navigating by keyboard. | |
| If the `tablist` precedes the `tabpanel` in source order, the user will expect to be able to step through the remaining tabs in focus order or select the <kbd>Down Arrow</kbd> to give focus to the visible tabpanel when navigating by keyboard. |
ericwbailey
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.