-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt ServiceWorkerContainer API to new events structure #13924
Conversation
This PR adapts the ServiceWorkerContainer API to conform to the new events structure.
@@ -9077,6 +9077,9 @@ | |||
/en-US/docs/Web/API/ServiceWorkerContainer.controller /en-US/docs/Web/API/ServiceWorkerContainer/controller | |||
/en-US/docs/Web/API/ServiceWorkerContainer.getRegistration([scope]) /en-US/docs/Web/API/ServiceWorkerContainer/getRegistration | |||
/en-US/docs/Web/API/ServiceWorkerContainer.register /en-US/docs/Web/API/ServiceWorkerContainer/register | |||
/en-US/docs/Web/API/ServiceWorkerContainer/oncontrollerchange /en-US/docs/Web/API/ServiceWorkerContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange. It looks like oncontrollerchange is removed and redirected to ServiceWorkerContainer? It should have been moved to controllerchange_event.
Changing the redirect file isn't the trick here :) I think there is a mistake where you deleted the Web/API/ServiceWorkerContainer/oncontrollerchange page instead of |
Ahh, that's what's been going on! Yeah, I probably ran |
This PR adapts the ServiceWorkerContainer API to conform to the new events structure.
BCD PR: mdn/browser-compat-data#15200