Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major revision: menuitem role #14447

Merged
merged 6 commits into from
May 6, 2022
Merged

Major revision: menuitem role #14447

merged 6 commits into from
May 6, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 29, 2022 •
edited
Loading

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner March 29, 2022 21:30
@estelle estelle requested review from ericwbailey and removed request for a team March 29, 2022 21:30
@estelle estelle marked this pull request as draft March 29, 2022 21:30
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Mar 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/menuitem_role
Title: ARIA: menuitem role
on GitHub

No new external URLs

(this comment was updated 2022-04-05 00:11:43.431122)

@estelle estelle marked this pull request as ready for review March 29, 2022 22:14
@estelle estelle mentioned this pull request Mar 29, 2022
Closed
42 tasks
@estelle estelle changed the title DRAFT: Major revision: menuitem role Major revision: menuitem role Mar 30, 2022
scottaohara
scottaohara reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only got a chance to quickly review this one.

files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menuitem_role/index.md Outdated Show resolved Hide resolved
@estelle @scottaohara
Apply suggestions from code review
db934a1 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle
Update files/en-us/web/accessibility/aria/roles/menuitem_role/index.md
2522372 
removed menu word from menu image since it is already in the role
@estelle estelle enabled auto-merge (squash) May 2, 2022 21:21
@estelle estelle merged commit 758d6f4 into mdn:main May 6, 2022
@estelle estelle deleted the menuitem branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@Rumyra Rumyra Rumyra approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @Rumyra @scottaohara