Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major revision: menubar role #14451

Merged
merged 5 commits into from
May 6, 2022
Merged

Major revision: menubar role #14451

merged 5 commits into from
May 6, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 30, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner March 30, 2022 00:14
@estelle estelle requested review from ericwbailey and removed request for a team March 30, 2022 00:14
@estelle estelle marked this pull request as draft March 30, 2022 00:14
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Mar 30, 2022
@estelle estelle mentioned this pull request Mar 30, 2022
Closed
42 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/menubar_role
Title: ARIA: menubar role
on GitHub

(this comment was updated 2022-04-04 23:42:32.332024)

@ericwbailey
Copy link
Member

Hi @estelle, noticed this is still in Draft status. Is it ready to review?

@estelle estelle changed the title DRAFT: Major revision: menubar role Major revision: menubar role Mar 31, 2022
@estelle estelle marked this pull request as ready for review March 31, 2022 03:02
@estelle
Copy link
Member Author

estelle commented Mar 31, 2022

@ericwbailey just took it out of draft. Linked to examples instead of writing new ones.

scottaohara
scottaohara reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggested updates. thank you

files/en-us/web/accessibility/aria/roles/menubar_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menubar_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menubar_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/menubar_role/index.md Outdated Show resolved Hide resolved
@estelle @scottaohara
Apply suggestions from code review
a066784 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle estelle enabled auto-merge (squash) May 2, 2022 21:20
@estelle estelle merged commit d038dc6 into mdn:main May 6, 2022
@estelle estelle deleted the menubar branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@Rumyra Rumyra Rumyra approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estelle @ericwbailey @Rumyra @scottaohara