Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Revision: combobox role #14534

Merged
merged 11 commits into from
May 6, 2022
Merged

Major Revision: combobox role #14534

merged 11 commits into from
May 6, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 1, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner April 1, 2022 04:19
@estelle estelle requested review from ericwbailey and removed request for a team April 1, 2022 04:19
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Apr 1, 2022
@estelle estelle mentioned this pull request Apr 1, 2022
Closed
42 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role
Title: ARIA: combobox role
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role
Title: ARIA: combobox role
on GitHub

No new external URLs

(this comment was updated 2022-04-04 23:40:08.279051)

@estelle estelle changed the title DRAFT: Major Revision: combobox role Major Revision: combobox role Apr 1, 2022
scottaohara
scottaohara reviewed Apr 2, 2022
View reviewed changes
Copy link
Contributor

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggested updates. Hope they are useful. Thanks!

files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
files/en-us/web/accessibility/aria/roles/combobox_role/index.md Outdated Show resolved Hide resolved
estelle and others added 7 commits April 4, 2022 16:31
@estelle @scottaohara
Update files/en-us/web/accessibility/aria/roles/combobox_role/index.md
50b44e1 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle @scottaohara
Update files/en-us/web/accessibility/aria/roles/combobox_role/index.md
e95ccd8 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle @scottaohara
Update files/en-us/web/accessibility/aria/roles/combobox_role/index.md
32bdf85 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle @scottaohara
Update files/en-us/web/accessibility/aria/roles/combobox_role/index.md
cec2fa0 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle @scottaohara
Apply suggestions from code review
0eb88c5 
commit all but 1 suggestion

Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle @scottaohara
Update files/en-us/web/accessibility/aria/roles/combobox_role/index.md
1a5da1c 
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
@estelle
simplified some text
de12103
@estelle estelle mentioned this pull request Apr 8, 2022
Closed
@estelle estelle linked an issue Apr 8, 2022 that may be closed by this pull request
Issue with "ARIA: combobox role": Combobox should contain a text field and options as children #14784
Closed
@estelle estelle enabled auto-merge (squash) May 2, 2022 21:20
@estelle estelle merged commit 4a84ffe into mdn:main May 6, 2022
@estelle estelle deleted the combo branch August 19, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@Rumyra Rumyra Rumyra approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "ARIA: combobox role": Combobox should contain a text field and options as children
3 participants
@estelle @Rumyra @scottaohara