-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OKLCH and OKLab functions to reference #15033
Conversation
Is there any browser implementing them? If not, we should wait before merging this. |
Safari TP mentions |
Assigning myself for review (I'm reorganizing CSS Colors). Before landing this, I want to be sure the BCD information is up-to-date, and the subpages created (the mention is pretty useless without them) |
Preview URLs
FlawsURL:
URL:
URL:
External URLsURL: No new external URLs URL:
URL:
(this comment was updated 2022-06-02 14:24:31.706526) |
@teoli2003 I added pages for I took
I also added Questions:
|
@teoli2003 just to clarity why I force these changes: The reason of this PR is not to add docs but to solve problem with CSS linters. They use MDN as a source of valid functions and right now, any CSS code with |
Hi, ai! No worry, I just didn't have enough time to go back to this. I will review this PR this week! |
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
@teoli2003 friendly ping for the glory of OKLCH 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks! Just a small question: will it deploy automatically or did I need another step to make it public? https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/oklch |
It will deploy automatically, in about 24h. |
I sent PR to compat data as well mdn/browser-compat-data#16526 |
Summary
I added OKLab color functions to CSS Functional Notation.
Motivation
They are part of CSS Color Modules 4.
Adding them to this list will fix Stylelint
function-no-unknown
since Stylelint uses this document as a source of all valid CSS function names.Supporting details
Safari TP should support these functions.
Metadata