Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add closing p tag #17659

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Add closing p tag #17659

merged 9 commits into from
Aug 25, 2022

Conversation

heyallan
Copy link
Contributor

Summary

Add closing p tag

Motivation

Closing p tag is not strictly required in specific cases,
but not closing it might be confusing without explanation,
adding a closing tag will not hurt.

Supporting details

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/p

Related issues

None

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@heyallan
Fix closing p tag
2f95f7a 
Closing p tag is not strictly required in **some cases**,
but not closing it might be confusing without explanation.
@heyallan heyallan requested a review from a team as a code owner June 26, 2022 03:11
@heyallan heyallan requested review from estelle and removed request for a team June 26, 2022 03:11
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jun 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2022 •
edited
Loading

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/:where
Title: :where()
on GitHub

No new external URLs

(this comment was updated 2022-08-25 00:12:22.629822)

wbamberg
wbamberg requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @heyallan ! I think we should have a "." inside the paragraph.

files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
heyallan and others added 6 commits June 28, 2022 16:54
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
469a45e 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
0063dde 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
003482e 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
5c176f3 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
3d33b1d 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
@heyallan @wbamberg
Update files/en-us/web/css/_colon_where/index.md
317e4ca 
Move period inside paragraph

Co-authored-by: wbamberg <will@bootbonnet.ca>
heyallan
heyallan commented Jun 28, 2022
View reviewed changes
Copy link
Contributor Author

@heyallan heyallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move period inside paragraph. Done.

estelle
estelle approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@heyallan heyallan requested a review from wbamberg June 28, 2022 23:14
@Josh-Cena Josh-Cena mentioned this pull request Jul 12, 2022
Closed
3 tasks
wbamberg
wbamberg approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry to be slow reviewing this @heyallan , I've been out of office for a while.

@wbamberg wbamberg merged commit 0358c82 into mdn:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyallan @estelle @wbamberg