-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demix media load events from GlobalEventHandlers #18311
Conversation
Preview URLs
FlawsNote! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLsURL: No new external URLs URL: No external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-07-23 04:44:33.229316) |
We also need an |
That's right. Because media element resources are fetched using range requests, the whole thing might never be loaded at the same time, so there's no event for that, just events like "canplaythrough". |
So does this mean that this comment:
is wrong? |
It's possible that Firefox had a non-standard |
Looks like "loadstart" and "loadend" events for Confirmed with https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10465. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a loadstart page that needs updating too?
Signed-off-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If I'm mistaken, let's open follow-up PRs.
This PR demixes the
load
event handlers for media elements from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16925