Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move pointerlock events to Element" #20890

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 19, 2022

Reverts #20806

I made a mistake. Pointerlock events are defined on the Document interface.

See mdn/browser-compat-data#17816

@Elchi3 Elchi3 requested review from a team as code owners September 19, 2022 13:03
@Elchi3 Elchi3 requested review from jpmedley, hamishwillee and bsmth and removed request for a team September 19, 2022 13:03
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Sep 19, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/Events
Title: Event reference
Flaw count: 65

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Document/wheel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationcancel_event
    • Can't resolve /en-US/docs/Web/API/Document/animationend_event
    • Can't resolve /en-US/docs/Web/API/Document/animationiteration_event
    • Can't resolve /en-US/docs/Web/API/Document/animationstart_event
    • and 60 more flaws omitted

URL: /en-US/docs/Web/API/Document
Title: Document
Flaw count: 55

  • macros:
    • /en-US/docs/Web/API/HTMLAllCollection does not exist
    • /en-US/docs/Web/API/Document/height redirects to /en-US/docs/Web/API/Element/clientHeight
    • /en-US/docs/Web/API/Document/width redirects to /en-US/docs/Web/API/Element/clientWidth
    • /en-US/docs/Web/API/Document/xmlStandalone does not exist
    • /en-US/docs/Web/API/Document/captureEvents does not exist
    • and 39 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/Document/pointerlockchange_event
Title: Document: pointerlockchange event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Document.pointerlockchange_event

URL: /en-US/docs/Web/API/Document/pointerlockerror_event
Title: Document: pointerlockerror event
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Document.pointerlockerror_event

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍🏻

@bsmth bsmth merged commit d461927 into main Sep 19, 2022
@bsmth bsmth deleted the revert-20806-pointerlock-events branch September 19, 2022 13:15
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants