Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected incorrect use of image #21366

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

akaabdullahmateen
Copy link
Contributor

Description

Changed usage of the word image to resource in attributes descriptions. And, corrected a small grammar mistake.

Motivation

There were two occurrence where image was incorrectly used, rather than the more general resource. Both inside the description of crossorigin: first under the enumerated value anonymous, second under the enumerated value use-credentials.

My guess is that, the description of the attribute crossorigin (of <video> element) was written with inspiration from the similarly named attribute (of <img> element). Hence, the word image being incorrectly used when video or more generally resource should have been used.

Also, with the grammar mistake (before changing used to use), it was hard to understand what the sentence meant.

Additional details

Related issues and pull requests

@akaabdullahmateen akaabdullahmateen requested a review from a team as a code owner October 7, 2022 15:48
@akaabdullahmateen akaabdullahmateen requested review from schalkneethling and removed request for a team October 7, 2022 15:48
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/HTML/Element/video
Title: <video>: The Video Embed element
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@estelle estelle merged commit c0c5632 into mdn:main Oct 7, 2022
@akaabdullahmateen akaabdullahmateen deleted the patch-5 branch October 7, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants