Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro and epoch name in Date.now() #21367

Merged
merged 4 commits into from
Oct 8, 2022
Merged

Conversation

mfuji09
Copy link
Contributor

@mfuji09 mfuji09 commented Oct 7, 2022

Description

Number shouldn't be a jsxref macro because it is linked to the wrapper objects.
And it should be "ECMAScript epoch" rather than "UNIX epoch".

Motivation

Additional details

Related issues and pull requests

@mfuji09 mfuji09 requested a review from a team as a code owner October 7, 2022 16:54
@mfuji09 mfuji09 requested review from wbamberg and removed request for a team October 7, 2022 16:55
@github-actions github-actions bot added the Content:JS JavaScript docs label Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Preview URLs

(this comment was updated 2022-10-08 12:48:29.886093)

@wbamberg wbamberg added the awaiting response Awaiting for author to address review/feedback label Oct 7, 2022
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @mfuji09 !

@wbamberg wbamberg merged commit 1e7de1a into mdn:main Oct 8, 2022
@mfuji09 mfuji09 deleted the 20221008-Date-now() branch October 10, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Awaiting for author to address review/feedback Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants