Document durationThreshold in PerfObserver.observe() #21552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs |
sideshowbarker
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/observe to add the
durationThresholdoption from the Event Timing API.Spec: https://w3c.github.io/event-timing/#sec-modifications-perf-timeline
Motivation
openwebdocs/project#62
Additional details
I also ordered the options list alphabetically and removed explicit mention of "
PerformanceObserverInitdictionary" because I believe we don't document dictionaries anymore and all we want readers to know is that it is an options object.Related issues and pull requests
In #21531 I'm adding more text to talk about
durationThresholdand I've added an example about it on thePerformanceEventTimingpage.