Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10 strings for static and instance methods and properties #21691

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Oct 20, 2022

This is the l10n companion to mdn/yari#7335, and adds the localised strings for static/instance methods/properties en-US, fr, es, zh-CN, so they can be shown in the sidebar. Other languages can be added in follow-up PRs.

To test:

  • check out Yari
  • check out this branch
  • point Yari's CONTENT_ROOT at this branch
  • visit some pages under Web/API in various languages:
    • en-US, fr, es, zh-CN should all show translated strings for "Static methods", "Static properties", "Instance methods", "Instance properties" in the sidebar
    • any other locales (e.g. ja, pt-BR) should show en-US strings

(like this: mdn/yari#7335 (comment))

This PR replaces #21690, which rotted.

@wbamberg wbamberg requested a review from a team as a code owner October 20, 2022 20:06
@wbamberg wbamberg requested review from bsmth and removed request for a team October 20, 2022 20:06
@teoli2003 teoli2003 merged commit 17b7c59 into mdn:main Oct 20, 2022
@wbamberg wbamberg deleted the l10n-static-instance-strings branch April 5, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants