Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PerformanceResourceTiming pages, part 2 #22577

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Update PerformanceResourceTiming pages, part 2 #22577

merged 4 commits into from
Nov 29, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 28, 2022 •
edited
Loading

Description

This PR updates the three content size related properties of the PerformanceResourceTiming interface.

  • decodedBodySize
  • encodedBodySize
  • transferSize

Motivation

openwebdocs/project#62

Additional details

For decodedBodySize and encodedBodySize I created example code that checks if content was compressed. For transferSize I created example code that checks if a local cache was hit. Let me know if these make sense. Another example for transferSize might be to raise warning if a resource is too large given some threshold or something.

Related issues and pull requests

Part 1 was done in #22503

@Elchi3 Elchi3 requested a review from a team as a code owner November 28, 2022 15:04
@Elchi3 Elchi3 requested review from jpmedley and removed request for a team November 28, 2022 15:04
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/API/PerformanceResourceTiming/transferSize
Title: PerformanceResourceTiming.transferSize

(comment last updated: 2022-11-29 15:40:14)

jpmedley
jpmedley requested changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand now that the phrases starting with 'Or' were introducing the next example. I changed them from sentence fragments to sentences.

files/en-us/web/api/performanceresourcetiming/decodedbodysize/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performanceresourcetiming/encodedbodysize/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performanceresourcetiming/transfersize/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/performanceresourcetiming/transfersize/index.md Outdated Show resolved Hide resolved
@Elchi3 @jpmedley
Apply suggestions from code review
01e2cd3 
Co-authored-by: Joe Medley <jmedley@google.com>
jpmedley
jpmedley approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience.

@jpmedley jpmedley merged commit 6f8d004 into mdn:main Nov 29, 2022
@Elchi3 Elchi3 deleted the resourcetiming-part2 branch November 29, 2022 15:50
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
@Elchi3 @jpmedley @hamishwillee
Update PerformanceResourceTiming pages, part 2 (mdn#22577)
9e9184c 
* Update PerformanceResourceTiming pages, part 2

* Tweak TAO wording

* Review feedback

* Apply suggestions from code review

Co-authored-by: Joe Medley <jmedley@google.com>

Co-authored-by: Joe Medley <jmedley@google.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpmedley jpmedley jpmedley approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @jpmedley