-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pages for Largest Contentful Paint #22822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
requested review from
sideshowbarker and
bsmth
and removed request for
a team
December 8, 2022 16:34
github-actions
bot
added
Content:Glossary
Glossary entries
Content:WebAPI
Web API docs
labels
Dec 8, 2022
sideshowbarker
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates https://developer.mozilla.org/en-US/docs/Web/API/LargestContentfulPaint (+ sub pages) and redirects https://developer.mozilla.org/en-US/docs/Web/API/Largest_Contentful_Paint_API to it given the overview page doesn't provide any additional value and we decided to present the Performance API as a single API to readers.
Motivation
openwebdocs/project#62
Additional details
I've also added a short glossary entry given other metrics like FP or FCP also have one.
Again, the cross origin case wasn't explained, so I added it.
Related issues and pull requests
None.