Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHIPS docs #23495

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Add CHIPS docs #23495

merged 10 commits into from
Jan 23, 2023

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jan 9, 2023

Description

This PR adds documentation for Cookies Having Independent Partitioned State (CHIPS)

See my research document for more information about this feature.

Motivation

Additional details

Related issues and pull requests

Fixes #23485

@chrisdavidmills chrisdavidmills requested review from a team as code owners January 9, 2023 15:04
@chrisdavidmills chrisdavidmills requested review from wbamberg and teoli2003 and removed request for a team January 9, 2023 15:04
@github-actions github-actions bot added Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jan 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Preview URLs (9 pages)
Flaws (2)

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CookieStore/set
Title: CookieStore.set()
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/serialize redirects to /en-US/docs/Glossary/Serialization

URL: /en-US/docs/Web/Privacy/Partitioned_cookies
Title: Cookies Having Independent Partitioned State (CHIPS)
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Set-Cookie.Partitioned
External URLs (8)

URL: /en-US/docs/Web/API/CookieStore/getAll
Title: CookieStore.getAll()


URL: /en-US/docs/Web/API/CookieStore/get
Title: CookieStore.get()


URL: /en-US/docs/Web/API/CookieStore/set
Title: CookieStore.set()


URL: /en-US/docs/Web/Privacy
Title: Privacy, permissions, and information security


URL: /en-US/docs/Web/Privacy/Partitioned_cookies
Title: Cookies Having Independent Partitioned State (CHIPS)

(comment last updated: 2023-01-23 07:39:31)

Copy link
Contributor

@DCtheTall DCtheTall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome we also added partitioned cookie support to the CookieStore API, do we want to include those changes in this PR as well?

files/en-us/web/http/cookies/index.md Outdated Show resolved Hide resolved
files/en-us/web/http/cookies/index.md Outdated Show resolved Hide resolved
files/en-us/web/privacy/partitioned_cookies/index.md Outdated Show resolved Hide resolved
@chrisdavidmills
Copy link
Contributor Author

Thanks for the review comments, @DCtheTall ! I've made the changes as suggested.

As for the updates to the CookieStore API, I'm assuming you are talking about the changes listed here: https://github.com/privacycg/CHIPS#cookiestore-api ? I could include them in the PR, but I've got a few questions first:

  1. Are they in a spec anywhere? I can't see them specified in https://wicg.github.io/cookie-store/.
  2. Are the proposals listed in the explainer actually equivalent to the final updates, or are there further updates to consider?
  3. What version of Chrome are they set to be released in? The same one as the rest of the CHIPS updates?
  4. Is there a ChromeStatus entry for these updates, or are they being dealt with in the same one as the rest of the CHIPS updates?

@DCtheTall
Copy link
Contributor

Hey @chrisdavidmills, to answer your questions:

  1. I opened a PR against the spec, Add support for partitioned cookies to CookieStore. WICG/cookie-store#206
  2. Yes, the changes in the explainer reflect the realized Chromium implementation.
  3. The CookieStore changes are umbrellaed under the entire partitioned cookies feature, there is no separate flag/control for the CookieStore.
  4. Same answer as 3, CookieStore changes are part of the larger partitioned cookies feature.

@chrisdavidmills
Copy link
Contributor Author

Hey @chrisdavidmills, to answer your questions:

1. I opened a PR against the spec, [Add support for partitioned cookies to CookieStore. WICG/cookie-store#206](https://github.com/WICG/cookie-store/pull/206)

2. Yes, the changes in the explainer reflect the realized Chromium implementation.

3. The CookieStore changes are umbrellaed under the entire partitioned cookies feature, there is no separate flag/control for the CookieStore.

4. Same answer as 3, CookieStore changes are part of the larger partitioned cookies feature.

All sounds good. I'll add them to this PR, and to mdn/browser-compat-data#18591.

@chrisdavidmills chrisdavidmills marked this pull request as draft January 11, 2023 07:50
@chrisdavidmills chrisdavidmills marked this pull request as ready for review January 11, 2023 09:17
@chrisdavidmills
Copy link
Contributor Author

@DCtheTall CookieStore additions added; let me know what you think. The preview URLs have been updated.

Copy link
Contributor

@DCtheTall DCtheTall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

files/en-us/web/privacy/partitioned_cookies/index.md Outdated Show resolved Hide resolved
@chrisdavidmills
Copy link
Contributor Author

@sideshowbarker this is another one that's had an extensive review, but basically just needs merging. Can you have a quick look?

@sideshowbarker sideshowbarker merged commit 98f4d08 into mdn:main Jan 23, 2023
@chrisdavidmills chrisdavidmills deleted the add-chips-docs branch January 23, 2023 10:03
@chrisdavidmills
Copy link
Contributor Author

Yay, cheers @sideshowbarker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent to document: Cookies having independent paritioned state (CHIPS)
3 participants