Document Document.activeElement and ShadowRoot.activeElement separately. #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Document/activeElement
chrisdavidmills
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
This looks great, thanks @Elchi3 . I've done a couple of minor copy edits, but this looks ready to merge now.
And yes, I think this is a good way to divide up the PRs and make reviews manageable. Thanks for being so considerate.
This was referenced Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot mixin is a bit larger, so I'm not sure how to make PRs reviewable, but I thought maybe going member by member makes sense.
So, this PR updates the docs so that we have Document.activeElement and ShadowRoot.activeElement separately instead of on an abstract mixin page https://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/activeElement
The BCD change happened in mdn/browser-compat-data#9045 (for the whole mixin).
Follow-up PRs for the other members coming.