Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24016 Link points to itself #24027

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Fixes #24016 Link points to itself #24027

merged 3 commits into from
Feb 1, 2023

Conversation

MaruthiKo
Copy link
Contributor

@MaruthiKo MaruthiKo commented Jan 31, 2023

Description

On this part of the docs:- https://developer.mozilla.org/en-US/docs/Web/CSS/Reference#index
The Note has a link that points to itself, I have added a necessary link

Motivation

When a reader clicks the link it does not provide any useful resource, instead, it points to itself, I have added a useful resource that helps the user better and gives a better understanding of it

On this part of the docs:- https://developer.mozilla.org/en-US/docs/Web/CSS/Reference#index
The Note has a link that points to itself 
I have added a necessary link
@MaruthiKo MaruthiKo requested a review from a team as a code owner January 31, 2023 16:27
@MaruthiKo MaruthiKo requested review from estelle and removed request for a team January 31, 2023 16:27
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Preview URLs

Flaws (14)

URL: /en-US/docs/Web/CSS/Reference
Title: CSS reference
Flaw count: 14

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • and 8 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Glossary/Descriptor_(CSS)

(comment last updated: 2023-02-01 19:56:20)

@bsmth
Copy link
Member

bsmth commented Jan 31, 2023

I think we need to mention this https://drafts.csswg.org/cssom/#css-property-to-idl-attribute somewhere in CSSOM. @estelle any opinion on where this should live?

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@estelle estelle self-assigned this Jan 31, 2023
@estelle
Copy link
Member

estelle commented Feb 1, 2023

I think we need to mention this https://drafts.csswg.org/cssom/#css-property-to-idl-attribute somewhere in CSSOM. @estelle any opinion on where this should live?

I think it should be its own page, linked to from https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle#notes. We likely should also add a CSS module landing page for this spec. The landing pages we have are listed here: openwebdocs/project#147

Submitted issue: #24084

@estelle estelle merged commit 4206577 into mdn:main Feb 1, 2023
@MaruthiKo MaruthiKo deleted the patch-2 branch February 2, 2023 03:48
@MaruthiKo MaruthiKo restored the patch-2 branch February 2, 2023 03:48
@MaruthiKo MaruthiKo deleted the patch-2 branch February 2, 2023 03:48
@MaruthiKo MaruthiKo restored the patch-2 branch February 2, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants