Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS property page: filter #24417

Merged
merged 23 commits into from
Feb 22, 2023
Merged

CSS property page: filter #24417

merged 23 commits into from
Feb 22, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 14, 2023

This was a guide. Now it's a proper filter page. Creating a guide to filter and backdrop filter in another PR.

Only one file changed
23 images deleted. one renamed.

@estelle estelle requested a review from a team as a code owner February 14, 2023 03:33
@estelle estelle requested review from dipikabh and removed request for a team February 14, 2023 03:33
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Feb 14, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023

Preview URLs

(comment last updated: 2023-02-21 20:24:54)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle! I've suggested a few edits.

files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
estelle and others added 3 commits February 14, 2023 15:43
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@yarusome
Copy link
Contributor

Currently the "Interpolation" section starts with:

When animated, if both the beginning and end filters have a function list of the same length without url(), each of their filter functions is interpolated according to its specific rules.

This implies that interpolation will happen between filter function lists of the same length even if the functions are of different orders, e.g.

img {
  filter: brightness(150%) contrast(50%);
  transition: 1s;
}
img:hover {
  filter: contrast(150%) brightness(50%);
}

but the actual animation is discrete.

@estelle
Copy link
Member Author

estelle commented Feb 15, 2023

Thank you. Updated.

but the actual animation is discrete.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @estelle. I have a few more comments.

files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter/index.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
estelle and others added 6 commits February 21, 2023 12:18
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@dipikabh dipikabh merged commit 784d447 into mdn:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants