Remove link to the constants DONE and UNSENT #24535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URLs (comment last updated: 2023-02-19 06:38:10) |
teoli2003
changed the title
Josh-Cena
reviewed
Feb 19, 2023
| @@ -10,7 +10,7 @@ browser-compat: api.XMLHttpRequest.abort | |||
| The **`XMLHttpRequest.abort()`** method aborts the request if | |||
| it has already been sent. When a request is aborted, its | |||
| {{domxref("XMLHttpRequest.readyState", "readyState")}} is changed to | |||
| {{domxref("XMLHttpRequest.UNSENT")}} (0) and the request's | |||
| `UNSENT` (0) and the request's | |||
There was a problem hiding this comment.
XMLHttpRequest.UNSENT is an actual JS entity. Even if we don't have a page for it (see also: #9156, I think we should at least have a mention of it on the XMLHttpRequest landing page), we should keep the XMLHttpRequest.UNSENT qualified name.
|
Yes, you are right, let's keep the prefix. |
Josh-Cena
approved these changes
Feb 19, 2023
|
It is; we don't document them on their page. (The state machine should, directly or indirectly, be explained somehow, somewhere). |
pmeenan
pushed a commit
to pmeenan/content
that referenced
this pull request
Feb 19, 2023
* Remove link to DONE * Remove link to UNSENT * Reprefix the const * Reprefix the const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't write separate pages for constants. Transforms the links to a simple text.