Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS filter function: contrast() #24990

Merged
merged 9 commits into from
Mar 3, 2023
Merged

CSS filter function: contrast() #24990

merged 9 commits into from
Mar 3, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 2, 2023

Includes 3 new examples.

@estelle estelle requested a review from a team as a code owner March 2, 2023 00:20
@estelle estelle requested review from dipikabh and removed request for a team March 2, 2023 00:20
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Preview URLs

(comment last updated: 2023-03-03 06:31:54)

@dipikabh dipikabh self-assigned this Mar 2, 2023
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Two small changes.

files/en-us/web/css/filter-function/contrast/index.md Outdated Show resolved Hide resolved
- : The contrast of the result, specified as a {{cssxref("<number>")}} or a {{cssxref("<percentage>")}}. A value under `100%` decreases the contrast, while a value over `100%` increases it. A value of `0%` will create an image that is completely gray, while a value of `100%` leaves the input unchanged. The initial value for {{Glossary("interpolation")}} is `1`.

## Examples
- : The contrast of the result, specified as a {{cssxref("<number>")}} or a {{cssxref("<percentage>")}}. A value under `100%` decreases the contrast, while a value over `100%` increases it. A value of `0` or `0%` will create an image that is completely gray, while a value of `1` or `100%` leaves the input unchanged. Negative values are not allowed. The initial value for {{Glossary("interpolation")}} is `1`.

### Setting contrast using numbers and percentages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under Examples

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont' think so. I didn't edit that part, but it's definitely explaining the parameter, not the examples that follow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed the parameter to values and changed the examples to pairs of values.

estelle and others added 2 commits March 2, 2023 16:52
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants