Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter function: brightness() #25057

Merged
merged 19 commits into from
Mar 21, 2023
Merged

Filter function: brightness() #25057

merged 19 commits into from
Mar 21, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Mar 3, 2023

This is the 3rd in the series. Revamped based on SC call feedback.

@estelle estelle requested a review from a team as a code owner March 3, 2023 22:14
@estelle estelle requested review from dipikabh and removed request for a team March 3, 2023 22:14
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/filter-function/brightness
Title: brightness()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/filter_effects

(comment last updated: 2023-03-20 15:44:06)

@estelle estelle mentioned this pull request Mar 10, 2023
Open
@dipikabh dipikabh self-assigned this Mar 15, 2023
@dipikabh
Copy link
Contributor

Sorry for the delay on this one, Estelle. Taking a look now.

dipikabh
dipikabh requested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize for the delay, @estelle. I've added my feedback.

files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Show resolved Hide resolved
estelle and others added 7 commits March 15, 2023 16:55
@estelle @dipikabh
Apply suggestions from code review
b35034e 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
Apply suggestions from code review
0a73d71 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
Apply suggestions from code review
db9607a 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
Update files/en-us/web/css/filter-function/brightness/index.md
050ac06 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh
Update files/en-us/web/css/filter-function/brightness/index.md
7026d65 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
intro
1b4e06b
@estelle
spacing (prettier)
428c964
@estelle estelle requested a review from dipikabh March 16, 2023 16:53
dipikabh
dipikabh requested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two remaining items - unhiding the html code and moving the example up, that is, the example "using the filter property" before the example "using the backdrop-filter property".

Plus code fencing is missing in two places

files/en-us/web/css/filter-function/brightness/index.md Show resolved Hide resolved
files/en-us/web/css/filter-function/brightness/index.md Show resolved Hide resolved
@estelle estelle requested a review from dipikabh March 20, 2023 15:39
dipikabh
dipikabh approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements to this page 👍

@dipikabh dipikabh merged commit be8cde8 into mdn:main Mar 21, 2023
@estelle estelle deleted the brightness branch July 14, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh